Split DWARFImporterDelegate into two parts. NFC #7722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. SwiftDWARFImporterForClangTypes is owned by a TypeSystemSwiftTypeRef. It imports Clang types from DWARF. 2. SwiftDWARFImporterDelegate is a swift::DWARFImporterDelegate that uses clang::ASTImporter to import a type from the TypeSystemClang used by the DWARFParser into the clang ASTContext used by one SwiftASTContext's ClangImporter. This is in preparation for creating more flexible SwiftASTContexts in the future.
|
@swift-ci test |
augusto2112
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftDWARFImporterForClangTypes is owned by a TypeSystemSwiftTypeRef. It imports Clang types from DWARF.
SwiftDWARFImporterDelegate is a swift::DWARFImporterDelegate that uses clang::ASTImporter to import a type from the TypeSystemClang used by the DWARFParser into the clang ASTContext used by one SwiftASTContext's ClangImporter.
This is in preparation for creating more flexible SwiftASTContexts in the future.