[lldb/Plugins] Add Swift Runtime Failure Recognizer #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add support for Swift Runtime Failure messages in the debugger. The trap failure messages is wrapped into an artificial inline function in the debug info, whose name is the actual error message. When a thread stops in one of these inlined frames, the recognizer fetch the function name and set it as the stop reason message and select the parent frame as the current one. rdar://53003975 Signed-off-by: Med Ismail Bennani <[email protected]>
|
@swift-ci please test |
|
Reviewed in #750. Create a new PR to accommodate the swift rebranch. |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Feb 18, 2020
The implementation was done quite a while ago. Now, that we have support in lldb (swiftlang/llvm-project#773), we can enable it by default in the compiler. LLDB now shows the runtime failure reason, for example: * thread #1, queue = 'com.apple.main-thread', stop reason = Swift runtime failure: arithmetic overflow frame #1: 0x0000000100000f0d a.out`testit(a=127) at trap_message.swift:4 1 2 @inline(never) 3 func testit(_ a: Int8) -> Int8 { -> 4 return a + 1 5 } 6 For details, see swiftlang#25978 rdar://problem/51278690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add support for Swift Runtime Failure messages in the debugger.
The trap failure messages is wrapped into an artificial inline function
in the debug info, whose name is the actual error message.
When a thread stops in one of these inlined frames, the recognizer fetch
the function name and set it as the stop reason message and select the
parent frame as the current one.
rdar://53003975
Signed-off-by: Med Ismail Bennani [email protected]