[dsymutil] Filter our swiftinterface files from the toolchain. (#71205) #7749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…71205) Dsymutil already avoids copying textual Swift interface files from the SDK, since any consumer would have to have a matching SDK installed anyway. It should also do the same thing with interfaces found in the toolchain itself, which includes the compiler built-in libraries such as Swift (=the standard library), and _Concurrency. rdar://117881604 (cherry picked from commit 71a1367) Conflicts: llvm/lib/DWARFLinkerParallel/DWARFLinkerCompileUnit.cpp
|
@swift-ci test |
|
@swift-ci test llvm |
I'm assuming that because sys::path::append defaults to native path this fails. Since dsymutil is a Darwin tool, we can just hardcode the UNIX path separator. (cherry picked from commit 2d460f2) Conflicts: llvm/lib/DWARFLinkerParallel/DWARFLinkerCompileUnit.cpp
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dsymutil already avoids copying textual Swift interface files from the SDK, since any consumer would have to have a matching SDK installed anyway. It should also do the same thing with interfaces found in the toolchain itself, which includes the compiler built-in libraries such as Swift (=the standard library), and _Concurrency.
rdar://117881604
(cherry picked from commit 71a1367)
Conflicts:
llvm/lib/DWARFLinkerParallel/DWARFLinkerCompileUnit.cpp