Skip to content

[Cherry-pick into stable/20230725] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (#71559) #7766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

[Cherry-pick into stable/20230725] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (#71559) #7766

merged 1 commit into from
Nov 14, 2023

Conversation

adrian-prantl
Copy link 

commit 767ce07c2d4c312188623441979d620b9708ee99
Author: Adrian Prantl <[email protected]>
Date:   Wed Nov 8 09:54:41 2023 -0800

    Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (#71559)
    
    I received a couple of nullptr-deref crash reports with no line numbers
    in this function. The way the function was written it was a bit
    diffucult to keep track of when result_sp could be null, so this patch
    simplifies the function to make it more obvious when a nullptr can be
    contained in the variable.

@adrian-prantl
Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (llvm#…
a3dac2e 
…71559)

I received a couple of nullptr-deref crash reports with no line numbers
in this function. The way the function was written it was a bit
diffucult to keep track of when result_sp could be null, so this patch
simplifies the function to make it more obvious when a nullptr can be
contained in the variable.

(cherry picked from commit 767ce07)
@adrian-prantl
Copy link
Author

@swift-ci test

@adrian-prantl
Copy link
Author

@swift-ci test windows

@adrian-prantl adrian-prantl merged commit c88cc4d into swiftlang:stable/20230725 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrian-prantl