Skip to content

[ConstraintElim] Make sure add-rec is for the current loop. #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

fhahn
Copy link

@fhahn fhahn commented Nov 11, 2023

Pick ConstraintElimination fix to make sure an AddRec is in the current loop.

In the added test case, the AddRec from the first loop is used
incorrectly in the second loop.

(cherry-picked from 0d48a46)
Update addInfoForInductions to also check if the add-rec is for the
current loop. Otherwise we might add incorrect facts or crash.

Fixes a miscompile & crash introduced by 00396e6.

(cherry-picked from 26ab444)
@fhahn
Copy link
Author

fhahn commented Nov 11, 2023

@swift-ci please test and merge

@fhahn
Copy link
Author

fhahn commented Nov 11, 2023

@swift-ci please test

@fhahn
Copy link
Author

fhahn commented Nov 12, 2023

@swift-ci please test windows

@fhahn fhahn merged commit ea3a029 into swiftlang:stable/20230725 Nov 12, 2023
@fhahn fhahn deleted the ce-fixes-stable-2023 branch November 12, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant