Add an include to xtr1common in ADL.h #7818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/xtr1common
branch
from
e25967d to
daf3abe
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
ahoppen/xtr1common
branch
from
daf3abe to
5217428
Compare
When including ADL.h in a header that is used from Swift using C++ interop, MSVC complains about a missing definition of `remove_reference_t` in ADL.h. Explicitly including `<xtr1common>` fixes the issue.
ahoppen
force-pushed
the
ahoppen/xtr1common
branch
from
5217428 to
0c1ff19
Compare
ahoppen
commented
Nov 28, 2023
| @@ -9,6 +9,9 @@ | |||
| #ifndef LLVM_ADT_ADL_H | |||
| #define LLVM_ADT_ADL_H | |||
|
|
|||
| #if defined(_MSC_VER) && _MSC_VER < 1937 | |||
There was a problem hiding this comment.
@compnerd You suggested checking for the following to me but that check did not evaluate to true in Windows CI.
#if defined(_MSVC_STL_UPDATE) && _MSVC_STL_UPDATE < 202305lBased on the _MSVC_STL_UPDATE <-> _MSC_VER mapping, I changed it to a check for _MSC_VER. Does this make sense to you?
There was a problem hiding this comment.
That doesn't really work. _MSC_VER is the compiler version, the problem here is the header version, which is _MSVC_STL_UPDATE. I think that we should just figure out what version is in use and use that.
There was a problem hiding this comment.
Do you have any suggestions I should try?
|
Looks like this is no longer needed because we’re no longer importing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including ADL.h in a header that is used from Swift using C++ interop, MSVC complains about a missing definition of
remove_reference_tin ADL.h.Explicitly including
<xtr1common>fixes the issue.