Skip to content

[lldb] Make GetClangTypeNode aware of SIMD types #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

augusto2112
Copy link

The compiler has some special handling for SIMD types, implement the same rules on TypeSystemSwiftTypeRef::GetClangTypeNode.

rdar://78567209

@augusto2112
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I have a few minor nitpicks inside.

@@ -170,6 +170,9 @@ simd_quatf(vector: colf4)
simd_quatd(vector: cold4)
// CHECK: $R{{.*}}: simd_quatd = (1.500000e+00, 2.000000e+00, 3.000000e+00, 4.000000e+00)

simd_quaternion(1.0, 0.5, 0.3, 0.1)
// CHECK: $R{{.*}}: simd_quatd = (1.000000e+00, 5.000000e-01, 3.000000e-01, 1.000000e-01)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The compiler has some special handling for SIMD types, implement the
same rules on TypeSystemSwiftTypeRef::GetClangTypeNode.

rdar://78567209
@augusto2112
Copy link
Author

@swift-ci test

@augusto2112
Copy link
Author

@swift-ci test Windows

@augusto2112 augusto2112 merged commit a4b2a1f into swiftlang:stable/20230725 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants