[lldb] Handle formatting C anonymous struct and unions in Swift #7850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
augusto2112
force-pushed
the
fix-anon-struct
branch
from
8489069 to
1dbd98d
Compare
|
@swift-ci test |
lldb/test/API/lang/swift/anonymous-clang-types/TestSwiftAnonymousClangTypes.py
Outdated
Show resolved
Hide resolved
lldb/test/API/lang/swift/anonymous-clang-types/TestSwiftAnonymousClangTypes.py
Outdated
Show resolved
Hide resolved
TypeSystemSwiftTypeRef handles Clang types by looking them up in debug information. This doesn't work for anonymous structs and unions, as: 1) they don't have a mangled name emitted in debug information 2) it's not possible to differentiate between multiple sibling anonymous structs/unions inside the same parent type. For these reasons, when encountering an anonymous type, return the clang type directly, instead of trying to convert it to Swift. rdar://96453293
augusto2112
force-pushed
the
fix-anon-struct
branch
from
1dbd98d to
8f297ca
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Dec 13, 2023
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
kastiglione
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeSystemSwiftTypeRef handles Clang types by looking them up in debug information. This doesn't work for anonymous structs and unions, as:
For these reasons, when encountering an anonymous type, return the clang type directly, instead of trying to convert it to Swift.
rdar://96453293