[lldb] Load embedded type summary section #7859
Conversation
kastiglione
force-pushed
the
dl/lldb-Load-embedded-type-summary-section
branch
from
5ce447d to
7f3c702
Compare
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Windows |
lldb/source/Target/Target.cpp
Outdated
| summaries_sp = data_sp->GetChildren().FindSectionByName( | ||
| ConstString("__lldbsummaries")); | ||
| } else if (triple.isOSLinux() || triple.isOSWindows()) { | ||
| summaries_sp = sections->FindSectionByName(ConstString(".lldbsummaries")); |
There was a problem hiding this comment.
This knowledge about the exact section name should be abstracted behind a virtual method in ObjectFile, which (at least in the LLVM variant) already has a mechanism to access differently named sections.
There was a problem hiding this comment.
Given that this is the only place the names are used, I wonder if it's worth adding abstraction, worth expanding the ObjectFile interface?
There was a problem hiding this comment.
There's also SwiftObjectFileFormat at swift/include/swift/ABI/ObjectFile.h
There was a problem hiding this comment.
Instead of putting forward a question, I will say: I think it's there's value in not adding abstraction in this case. My arguments against adding an abstraction are:
- These names aren't used anywhere else, and I don't see that changing
- Divides the knowledge across multiple files vs having the names in one place
- Expands the API of
ObjectFileetc
If in the future these names do get used from multiple locations, the abstraction can be added at that time.
There was a problem hiding this comment.
What do you think about adding cases to FindSectionByType?
https://lldb.llvm.org/cpp_reference/classlldb__private_1_1SectionList.html#ad8f56673377eb9d1fc130724d1ef6a4f
There was a problem hiding this comment.
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
Add support for type summaries embedded into the binary. These embedded summaries will typically be generated by macros, but can be generated by any other means. rdar://115184658 (cherry picked from commit a614c4d)
…#8040) Add support for type summaries embedded into the binary. These embedded summaries will typically be generated by Swift macros, but can also be generated by any other means. rdar://115184658
…#8040) Add support for type summaries embedded into the binary. These embedded summaries will typically be generated by Swift macros, but can also be generated by any other means. rdar://115184658
…#8040) Add support for type summaries embedded into the binary. These embedded summaries will typically be generated by Swift macros, but can also be generated by any other means. rdar://115184658
Add support for type summaries embedded into the binary.
These embedded summaries will typically be generated by macros, but can be generated by any other means.
rdar://115184658