Cherry-pick PR #7811 to stable/20230725 #7908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIEDedupeTopLevelRef is a CAS block that holds no data and has references to DIEDataRef CAS blocks. This makes it easy to check that a DIETopLevelRef in a CAS is valid, as it should only have 3 references to it, a DIEDedupeTopLevelRef, a DIEAbbrevSetRef, and a DIEDistinctDataRef (cherry picked from commit 2a479c0)
With this change, the layout of the debug info section in MCCAS has been changed. Now, if there is a DIE that can be split off into it's own CAS block, we do not attach it to its parent CAS block as a reference, it gets added as a neighbor instead. This reduces the dependencies between CAS blocks and increases chances of deduplication if a DIEDataRef doesn't dedupe, by making sure it's parent will still dedupe. This change also re-writes the materialization of the debug info section to be iterative, rather than recursive. (cherry picked from commit 038c057)
… references (cherry picked from commit db0871f)
(cherry picked from commit d91e87e)
|
@swift-ci please test |
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.