Makefile.rules: Replace Swift frontend invocations with Swift driver #7971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
augusto2112,
kastiglione,
JDevlieghere and
artemcm
|
@swift-ci test |
kastiglione
reviewed
Jan 16, 2024
| # FIXME: This should work with precise compiler invocations. | ||
| #self.expect("expression foo", "expected result", substrs=["$R3", "23"]) | ||
| #self.expect("expression $R3", "expected result", substrs=["23"]) | ||
| #self.expect("expression $R4", "expected result", substrs=["23"]) |
There was a problem hiding this comment.
same question, should this remain commented out?
There was a problem hiding this comment.
This looks like a regression, but in reality the output here is random based on the order in which modules are visited. The right thing to do is to enable this only when precise compiler invocations are on, but the decorator isn't powerful enough to detect this. I'll need to follow-up here.
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
b88cc96 to
3671b97
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
3671b97 to
82fc2d4
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
82fc2d4 to
73ade8b
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
73ade8b to
1188065
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
I just need to fix up Linux now. |
kastiglione
reviewed
Jan 17, 2024
lldb/test/API/lang/swift/explicit_modules/TestSwiftExplicitModules.py
Outdated
Show resolved
Hide resolved
lldb/test/API/lang/swift/explicit_modules/TestSwiftExplicitModules.py
Outdated
Show resolved
Hide resolved
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
1188065 to
f4f3e00
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
f4f3e00 to
666c7c3
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
666c7c3 to
6d2114a
Compare
|
@swift-ci test |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
6d2114a to
8a80169
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
2 times, most recently
from
5816ecd to
8ad3b48
Compare
|
@swift-ci test |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
8ad3b48 to
c31fef0
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
c31fef0 to
e5f27f1
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
2 times, most recently
from
9dcd3b3 to
d6845b9
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Currently Makefile.rules micro-manages Swift compilation, which is great for control, but also risky because the testsuite doesn't track new behavior in the Swift driver. As the Swift driver gains more and more build system functionality (e.g., explicit modules) we can simplify our Makefile while getting closer to what users actually see when using the Swift driver or build systems that include it as a library. The most notable difference this patch introduces is that we will now compile all Swift sources in a single Swift driver invocation, generating an output file list.
|
@swift-ci test linux |
adrian-prantl
force-pushed
the
embrace-swift-driver
branch
from
d6845b9 to
a0dd1e2
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Makefile.rules micro-manages Swift compilation, which is great for control, but also risky because the testsuite doesn't track new behavior in the Swift driver. As the Swift driver gains more and more build system functionality (e.g., explicit modules) we can simplify our Makefile while getting closer to what users actually see when using the Swift driver or build systems that include it as a library.
The most notable difference this patch introduces is that we will now compile all Swift sources in a single Swift driver invocation, generating an output file list.