Skip to content

[lldb][test] Remove unnecessary mydir assignments (NFC) #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

@kastiglione kastiglione commented Jan 17, 2024

The default location of mydir is determined in lldbtest.py. Tests only need to define it if they need a custom location. Each of these TestBase.compute_mydir(__file__) definitions is redundant. This PR changes Swift specific tests.

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione merged commit b6ab783 into stable/20230725 Jan 18, 2024
@kastiglione kastiglione deleted the dl/lldb-test-Remove-unnecessary-mydir-assignments-NFC branch January 18, 2024 18:08
kastiglione added a commit that referenced this pull request Mar 7, 2024
The default location of `mydir` is determined in `lldbtest.py`. Tests only need to
define it if they need a custom location. Each of these
`TestBase.compute_mydir(__file__)` definitions is redundant. This PR changes Swift
specific tests.

(cherry picked from commit b6ab783)
kastiglione added a commit that referenced this pull request Mar 7, 2024
The default location of `mydir` is determined in `lldbtest.py`. Tests only need to
define it if they need a custom location. Each of these
`TestBase.compute_mydir(__file__)` definitions is redundant. This PR changes Swift
specific tests.

(cherry picked from commit b6ab783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant