[-Wunsafe-buffer-usage]Fix for crash introduced by the DataInvocation Gadget #8018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of span::data warning (llvm#78815) The patch fixes the crash introduced by the DataInvocation warning gadget designed to warn against unsafe invocations of span::data method. It also now considers the invocation of span::data method inside parenthesis. Radar: 121223051 --------- Co-authored-by: MalavikaSamak <[email protected]> (cherry picked from commit 414df70)
This patch fixes: clang/lib/Sema/AnalysisBasedWarnings.cpp:2269:21: error: unused variable 'subExpr' [-Werror,-Wunused-variable] (cherry picked from commit 73ff017)
|
@swift-ci test |
malavikasamak
deleted the
unsafe-buffer-usage-data-inv-crash-fix-cherrypick
branch
malavikasamak
restored the
unsafe-buffer-usage-data-inv-crash-fix-cherrypick
branch
malavikasamak
deleted the
unsafe-buffer-usage-data-inv-crash-fix-cherrypick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radar: 121223051