[lldb] Add color support to StreamString (cherry pick) #8019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change just adds a `bool colors` parameter to the `StreamString` class's constructor, which it passes up to its superclass’s constructor. I'm working on another patch that prints out error messages using a `StreamString` but I wasn't getting colorized text because of this missing implementation detail. rdar://120671168
|
@swift-ci test |
adrian-prantl
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just adds a
bool colorsparameter to theStreamStringclass's constructor, which it passes up to its superclass’s constructor.I'm working on another patch that prints out error messages using a
StreamStringbut I wasn't getting colorized text because of this missing implementation detail.Original PR:
llvm#77380
rdar://120671168
Note
I renamed my branch to
apple/misc/streamstring-gets-color-cherrypick.You can now find it here:
https://github.com/PortalPete/llvm-project/tree/apple/misc/streamstring-gets-color-cherrypick