Pass UseCASBackend flag to replayCachedResult (cherry-pick https://github.com/apple/llvm-project/pull/8002 to stable/20230725 branch) #8023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using MCCAS, the replay on a cache hit needs to materialize the object file by calling into MCCAS's serializeObjectFile function. Pass the UseCASBackend flag from the CodeGenOpts to replayCachedResult to make sure it knows when to invoke MCCAS serialization. (cherry picked from commit 1fe3f3a)
rastogishubham
requested review from
akyrtzi,
benlangmuir and
cachemeifyoucan
|
@swift-ci please test |
rastogishubham
changed the title
akyrtzi
approved these changes
Jan 23, 2024
rastogishubham
changed the title
rastogishubham
changed the title
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MCCAS, the replay on a cache hit needs to materialize the object file by calling into MCCAS's serializeObjectFile function. Pass the UseCASBackend flag from the CodeGenOpts to replayCachedResult to make sure it knows when to invoke MCCAS serialization.
(cherry picked from commit 1fe3f3a)