Improve wording of progress update #8093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... assuming that nobody outside of LLDB developers knows what a "compile unit import" is.
adrian-prantl
requested review from
chelcassanova,
medismailben,
kastiglione and
JDevlieghere
|
@swift-ci test |
| compile_unit->GetPrimaryFile().GetFilename().GetCString(), | ||
| cu_imports.size()); | ||
| std::string category = "Importing Swift module dependencies for "; | ||
| category += compile_unit->GetPrimaryFile().GetFilename(); |
There was a problem hiding this comment.
Would main.swift always be the primary filename here? The category would be "Importing Swift module dependencies for main.swift" which I think works as a category name (as opposed to "Importing Swift module dependencies for"), I just wanna make sure that the filename here wouldn't change.
There was a problem hiding this comment.
The idea is we're debugging main.swift, which contains
import Foundation
import Cocoa
and then we should get:
Importing Swift module dependencies for main.swift: Foundation
Importing Swift module dependencies for main.swift: Cocoa
JDevlieghere
approved these changes
Feb 1, 2024
medismailben
reviewed
Feb 2, 2024
| @@ -38,14 +38,16 @@ def test_swift_progress_report(self): | |||
| "Loading Swift module", | |||
| "Importing modules used in expression", | |||
| "Setting up Swift reflection", | |||
| "Getting Swift compile unit imports", | |||
| "Importing Swift module dependencies for main.swift", | |||
There was a problem hiding this comment.
nit: We're only doing partial string matching on the test so we could have drop the file name at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve wording of progress update assuming that nobody outside of LLDB developers knows what a "compile unit import" is.