[Cherry-pick] Patches related to dwarf linker #8094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last use was removed by: commit be91b4e Author: Jonas Devlieghere <[email protected]> Date: Fri Mar 31 09:45:06 2023 -0700 (cherry picked from commit 7ea9d95)
(cherry picked from commit 1f929aa)
Use createTemporaryFile in favor of the TempFile abstraction to ensure we have an on-disk file. This fixes an issue on Windows where the DWARF verifier would fail when trying to open the temporary file from disk. (cherry picked from commit a04879c)
Dump verification errors to a local buffer instead of racing stdio and potentially showing interleaved output. (cherry picked from commit 4d1d8a8)
When processing multiple architectures in parallel, we need to protect access to stdio with a mutex. We already have a mutex for that purpose, but it was only used in the DWARFLinker. This patch protects writes to stdio in driver. (cherry picked from commit 74727a4)
|
@swift-ci test |
…ARFLinkerParallel. This patch is extracted from D96035, it adds support for the existing DWARFLinker functionality. What is not supported yet: 1. Types deduplication(--odr mode). 2. Modules deduplication. 3. Generation of index tables. Reland2: temporarily disabled call to "--linker llvm" for tls-variable.test and location-expression.test as it does not work properly on bigendian architecture. Differential Revision: https://reviews.llvm.org/D153268
felipepiovezan
force-pushed
the
felipe/cherry-picks-debugnames1
branch
from
f719536 to
d040b86
Compare
|
@swift-ci test |
JDevlieghere
approved these changes
Feb 1, 2024
adrian-prantl
approved these changes
Feb 1, 2024
|
@swift-ci test platform windows |
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another wave of cherry-picks from llvm.org with the ultimate goal of cherry-picking the debug_names work that has been done.
Before we can change AccelTable.cpp/.h, there are indirect dependencies with DWARFLinker (parallel and dsymutil) that must be cherry-picked (a lot of work was done upstream to refactor these entities). This PR handles some of those.