[clang][DependencyScanner] Remove unused -ivfsoverlay files #8095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using getName has the wrong behavior for VFSs, as it uses the external name, thus not using the VFS when looking up the modulemap. This differs in various downstreams, but has been fixed properly in llvm/main. Some commit hashes for context: 72cf785051fb1 e2cf37ce48df7 92c2507d3ceb3 b092f41 rdar://problem/24116019
Without this scanning will continue and later hit an assert that the number of `RedirectingFileSystem`s matches the number of -ivfsoverlay arguments. (cherry picked from commit b21a2f9)
`-ivfsoverlay` files are unused when building most modules. Enable removing them by, * adding a way to visit the filesystem tree with extensible RTTI to access each `RedirectingFileSystem`. * Adding tracking to `RedirectingFileSystem` to record when it actually redirects a file access. * Storing this information in each PCM. Usage tracking is only enabled when iterating over the source manager and affecting modulemaps. Here each path is stated to cause an access. During scanning these stats all hit the cache. llvm#73734 rdar://118030978
|
@swift-ci test |
jansvoboda11
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of llvm#73734 into stable/20230725.
There are also two other commits: