[5.10] Remove a bogus assertion. #8129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of recomputing the type of an LValue may be different from the type we find serialized with that LValue, either due to differing type sugar in a redeclaration, or more significantly due to a later declaration of a variable having an array bound that a prior declaration did not have. Therefore this assertion was attempting to verify a property that isn't necessarily true. (cherry-picked commit 2009f24)
|
@swift-ci please test |
compnerd
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of recomputing the type of an LValue may be different from the type we find serialized with that LValue, either due to differing type sugar in a redeclaration, or more significantly due to a later declaration of a variable having an array bound that a prior declaration did not have. Therefore this assertion was attempting to verify a property that isn't necessarily true.
(cherry-picked commit 2009f24)
Needed to build Arc browser with Swift 5.10