[lldb] Skip null bytes in embedded type summaries #8132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
|
@swift-ci test linux |
|
@swift-ci test windows |
| // Skip null bytes. Can happen with alignment padding. | ||
| while (true) { | ||
| auto next_offset = offset; | ||
| if (extractor.GetU8(&next_offset) != 0) { |
There was a problem hiding this comment.
Why is next_offset needed? Does GetU8 modify the parameter in the failure case?
There was a problem hiding this comment.
yes, the passed in offset is an in-out parameter. As far as GetU8 is concerned, reading a zero byte is not a failure case. If there was a PeekU8 method that would be better suited.
There was a problem hiding this comment.
No this is fine. I misread the condition, as checking for an error, but it's checking for the NUL byte.
adrian-prantl
approved these changes
Feb 8, 2024
| // Skip null bytes. Can happen with alignment padding. | ||
| while (true) { | ||
| auto next_offset = offset; | ||
| if (extractor.GetU8(&next_offset) != 0) { |
There was a problem hiding this comment.
No this is fine. I misread the condition, as checking for an error, but it's checking for the NUL byte.
kastiglione
deleted the
dl/lldb-Skip-null-bytes-in-embedded-type-summaries
branch
kastiglione
added a commit
that referenced
this pull request
Feb 16, 2024
Handle null padding that may exists between embedded type summary records. This can happen for example on x86-64 where the default alignment of `char[]` is 16 (p2align = 4). (cherry-picked from commit 87ace14)
kastiglione
added a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle null padding that may exists between embedded type summary records. This can happen for example on x86-64 where the default alignment of
char[]is 16 (p2align = 4).