Add SwiftLanguageRuntime support for implicit enum members. #8146
+138
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the changes in this commit were triggered by the new assertion. |
|
@swift-ci test |
augusto2112
requested changes
Feb 7, 2024
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
To verify this I also added a new assertion that replaces the // FIXME unimplemented comments sprinkled over the code. This uncoverd a bunch mre bugs related to implicit fields that are also fixed in this patch. One issue with nested enums is described in a comment but not yet fixed.
adrian-prantl
force-pushed
the
implicit-fields
branch
from
b2a395b to
aeb25ee
Compare
|
@swift-ci test |
|
@swift-ci test windows |
augusto2112
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To verify this I also added a new assertion that replaces the // FIXME unimplemented comments sprinkled over the code. This uncoverd a bunch mre bugs related to implicit fields that are also fixed in this patch. One issue with nested enums is described in a comment but not yet fixed.