[cherry-pick][stable/20230725] [lldb] Add std::chrono and std::valarray libc++ formatters #8190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Michael137
force-pushed
the
lldb/libcxx-formatters-to-20230725
branch
3 times, most recently
from
7530adb to
667d213
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
adrian-prantl
approved these changes
Feb 16, 2024
…roughout formatters (llvm#80133) This avoids duplicating the logic to get the first element of a libc++ `__compressed_pair`. This will be useful in supporting upcoming changes to the layout of `__compressed_pair`. Drive-by changes: * Renamed `m_item` to `size_node` for readability; `m_item` suggests it's a member variable, which it is not. (cherry picked from commit 08c0eb1)
…eturn an enum (llvm#80167) This patch changes the return value of `SyntheticChildrenFrontend::Update` to a scoped enum that aims to describe what the return value means. (cherry picked from commit d7fb94b)
The code is heavily based on the vector data formatter. (cherry picked from commit 5e9eaf8)
This adds the data formatters for chrono duration typedefs. Reviewed By: Michael137 Differential Revision: https://reviews.llvm.org/D159127 (cherry picked from commit 0e4264a)
This adds a subset of the C++20 calendar data formatters: - day, - month, - year, - month_day, - month_day_last, and - year_month_day. A followup patch will add the missing calendar data formatters: - weekday, - weekday_indexed, - weekday_last, - month_weekday, - month_weekday_last, - year_month, - year_month_day_last - year_month_weekday, and - year_month_weekday_last. (cherry picked from commit b5f2db9)
This is a followup of llvm#76983 and adds the libc++ data formatters for - weekday, - weekday_indexed, - weekday_last, - month_weekday, - month_weekday_last, - year_month, - year_month_day_last - year_month_weekday, and - year_month_weekday_last. (cherry picked from commit e3fde34)
(cherry picked from commit bfd12f3)
This formatter llvm#78609 was originally passing the signed seconds (which can refer to times in the past) with an unsigned printf formatter, and had tests that expected to see negative values from the printf which always failed on macOS. I'm not clear how they ever passed on any platform. Fix the printf to print seconds as a signed value, and re-enable the tests. (cherry picked from commit f219cda)
Michael137
force-pushed
the
lldb/libcxx-formatters-to-20230725
branch
from
667d213 to
963722e
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
…e() API This patch adapts the Swift formatters to the new return type of the `TypeSynthetic::Update` API. * `return false` -> `ChildCacheState::eRefetch` * `return true` -> `ChildCacheState::eReuse`
Michael137
force-pushed
the
lldb/libcxx-formatters-to-20230725
branch
from
963722e to
7ad9b8a
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cherry-picks various libc++ formatters for
std::chronoandstd::valarray. It also cherry-picks some pre-requisite NFC commits to reduce merge conflicts.