[-Wunsafe-buffer-usage] Fix fixits for span initialized from const si… #8231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze array (llvm#81927) Example: int arr[10]; int * ptr = arr; If ptr is unsafe and we transform it to std::span then the fixit we'd currently provide transforms the code to: std::span<int> ptr{arr, 10}; That's suboptimal as that repeats the size of the array in the code. The idiomatic transformation should rely on the span constructor that takes just the array argument and relies on template parameter autodeduction to set the span size. The transformed code should look like: std::span<int> ptr = arr; Note that it just should not change the initializer at all and that also works for other forms of initialization like: int * ptr {arr}; becoming: std::span<int> ptr{arr}; This patch changes the initializer handling to the desired (empty) fixit. (cherry picked from commit 7c3ad9e)
|
@swift-ci please test |
|
@swift-ci please test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ze array (llvm#81927)
Example:
int arr[10];
int * ptr = arr;
If ptr is unsafe and we transform it to std::span then the fixit we'd currently provide transforms the code to:
std::span ptr{arr, 10};
That's suboptimal as that repeats the size of the array in the code. The idiomatic transformation should rely on the span constructor that takes just the array argument and relies on template parameter autodeduction to set the span size.
The transformed code should look like:
std::span ptr = arr;
Note that it just should not change the initializer at all and that also works for other forms of initialization like:
int * ptr {arr};
becoming:
std::span ptr{arr};
This patch changes the initializer handling to the desired (empty) fixit.
(cherry picked from commit 7c3ad9e)