Skip to content

[lldb][test] XFAIL TestCppReferenceToOuterClass.py for now #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael137
Copy link

The intention was to only fail this test when
plugin.typesystem.clang.experimental-redecl-completion=false, but it seems like when the setting is not passed explicitly to dotest the decorator is a no-op.

XFAIL this again until we figure out the decoartor properly.

Copy link

@rastogishubham rastogishubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Michael137
Copy link
Author

@swift-ci test

@rastogishubham
Copy link

@swift-ci please test

@Michael137
Copy link
Author

@swift-ci test

@Michael137
Copy link
Author

@swift-ci test Windows

1 similar comment
@Michael137
Copy link
Author

@swift-ci test Windows

@Michael137 Michael137 force-pushed the lldb/type-completion-rework/WIP/xfail-to-20230725 branch 2 times, most recently from dc6939e to 9603b12 Compare February 23, 2024 01:01
@Michael137
Copy link
Author

@swift-ci test

@Michael137
Copy link
Author

@swift-ci test Windows

2 similar comments
@Michael137
Copy link
Author

@swift-ci test Windows

@Michael137
Copy link
Author

@swift-ci test Windows

@Michael137
Copy link
Author

@swift-ci tet Windows

The intention was to only fail this test when
`plugin.typesystem.clang.experimental-redecl-completion=false`, but
it seems like when the setting is not passed explicitly to `dotest`
the decorator is a no-op.

XFAIL this again until we figure out the decoartor properly.
@Michael137 Michael137 force-pushed the lldb/type-completion-rework/WIP/xfail-to-20230725 branch from 9603b12 to d62d3c1 Compare February 23, 2024 08:47
@Michael137
Copy link
Author

@swift-ci test

@Michael137
Copy link
Author

@swift-ci test Windows

@Michael137
Copy link
Author

@swift-ci test

@Michael137 Michael137 merged commit 6586a11 into stable/20230725 Feb 23, 2024
@Michael137 Michael137 deleted the lldb/type-completion-rework/WIP/xfail-to-20230725 branch February 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants