forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 341
[lldb][test] XFAIL TestCppReferenceToOuterClass.py for now #8261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Michael137
merged 2 commits into
stable/20230725
from
lldb/type-completion-rework/WIP/xfail-to-20230725
Feb 23, 2024
Merged
[lldb][test] XFAIL TestCppReferenceToOuterClass.py for now #8261
Michael137
merged 2 commits into
stable/20230725
from
lldb/type-completion-rework/WIP/xfail-to-20230725
Feb 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@swift-ci test |
@swift-ci please test |
@swift-ci test |
@swift-ci test Windows |
1 similar comment
@swift-ci test Windows |
dc6939e
to
9603b12
Compare
@swift-ci test |
@swift-ci test Windows |
@swift-ci tet Windows |
The intention was to only fail this test when `plugin.typesystem.clang.experimental-redecl-completion=false`, but it seems like when the setting is not passed explicitly to `dotest` the decorator is a no-op. XFAIL this again until we figure out the decoartor properly.
9603b12
to
d62d3c1
Compare
@swift-ci test |
@swift-ci test Windows |
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention was to only fail this test when
plugin.typesystem.clang.experimental-redecl-completion=false
, but it seems like when the setting is not passed explicitly todotest
the decorator is a no-op.XFAIL this again until we figure out the decoartor properly.