Skip to content

[lldb] Add experimental setting for Swift explicit modules #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

No description provided.

@kastiglione
Copy link
Author

@swift-ci test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but could this be tested in lldb/test/API/lang/swift/explicit_modules/ by adding a second function that is modeled after /lldb/test/API/lang/swift/module_import/TestSwiftModuleImport.py?

@kastiglione
Copy link
Author

Since we discussed getting this setting into the build quickly, I will merge this and add a test in a follow up. This function being changed doesn't directly produce any logs, so I'll either need to add some logs or figure out which logs can be relied on for a test.

@kastiglione kastiglione merged commit 22782c4 into stable/20230725 Feb 28, 2024
@kastiglione kastiglione deleted the dl/lldb-Add-experimental-setting-for-Swift-explicit-modules branch February 28, 2024 21:32
kastiglione added a commit that referenced this pull request Mar 7, 2024
kastiglione added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants