Fix bug with -fcas-emit-casid-file during replay. #8340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using MCCAS replay with the option -fcas-emit-casid-file, we would see the error: fatal error: caching backend error: cached output file has unknown path <path-to-file>/file.casid This patch fixes that issue by just having a raw_fd_ostream in the CompilerInstance that points to the .casid file rather than having it be one of the outputs of the CompilerInstance. This patch also makes sure that the .casid file is written even if there is a ResultCallback in the MachOCASWriter. (cherry picked from commit 2cd3dc3)
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using MCCAS replay with the option -fcas-emit-casid-file, we would see the error:
fatal error: caching backend error: cached output file has unknown path /file.casid
This patch fixes that issue by just having a raw_fd_ostream in the CompilerInstance that points to the .casid file rather than having it be one of the outputs of the CompilerInstance.
This patch also makes sure that the .casid file is written even if there is a ResultCallback in the MachOCASWriter.
(cherry picked from commit 2cd3dc3)