[lldb] Add test dependency on the runtimes instead of the cxx target
#8351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @JDevlieghere @adrian-prantl @hjyamauchi Cherry-picking this as the Windows build uses the runtimes build which needs this change to fix the dependencies for the tests. |
|
@swift-ci please test |
|
@compnerd can you rerun the mac CI? |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding individual dependencies on the enabled runtimes, make the
lldb-test-dependstarget depend on theruntimestarget. Thecxxtarget broke after 0fc8f0b.(cherry picked from commit dfa3570)