forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 342
[lldb] Fallback to implicit modules when explicit modules are missing #8356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kastiglione
merged 9 commits into
stable/20230725
from
dl/lldb-Fallback-to-implicit-modules-when-explicit-modules-are-missing
Mar 15, 2024
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
00c0668
[lldb] Fallback to implicit modules when explicit modules are missing
kastiglione b491088
Remove explicit module maps too
kastiglione 4ae9c2a
Handle both formats of -fmodule-file=
kastiglione d458902
Add test
kastiglione 610d19f
Replace auto with std::string
kastiglione f2f5d0b
Check that implicit modules are loaded
kastiglione 0829c9f
Remove check that isn't working in CI
kastiglione b7265d4
Debug linux CI
kastiglione da5163d
Disable test on Linux
kastiglione File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately you'll need to either use
path.str()
or add a HEALTH_LOG macro that takes LLVM formats. There is no guarantee that .data() is nullterminated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The StringRef references a std::string, which I understand would it a guarantee that
data
is null terminated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const auto &
withconst std::string &
then to guard against future modificationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do HEALTH_LOG in an isolated change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced
auto
withstd::string
in 610d19f