[clang][deps][cas] Fix include-tree contents with -working-directory #8367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test llvm |
cachemeifyoucan
approved these changes
Mar 8, 2024
After the -working-directory fix, this test needs to use a relative path for "ReadFiles". Note: This test already used a relative path upstream, but was modified downstream.
When using -working-directory we were inconsistent about using relative or absolute paths, which was causing failures to find files in the include-tree filesystem. Now we should be consistently using the absolute path. Note: this changes behaviour of things like __FILE__, which would normally have a relative path even with -working-directory. In the future we may want to find a way to preserve the relative paths, but that has been much harder and the current change at fixes the compilation failures. rdar://116135029
benlangmuir
force-pushed
the
working-directory-include-tree
branch
from
c51aaec to
78e64df
Compare
|
@swift-ci please test llvm |
jansvoboda11
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is llvm#84525 and will be rebased before merging.
When using -working-directory we were inconsistent about using relativeor absolute paths, which was causing failures to find files in the include-tree filesystem. Now we should be consistently using theabsolute path.
Note: this changes behaviour of things like
__FILE__, which would normally have a relative path even with -working-directory. In the future we may want to find a way to preserve the relative paths, but that has been much harder and the current change at fixes the compilation failures.rdar://116135029