[lldb] Only use Swift remark diagnostics for logging #8371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test windows |
al45tair
reviewed
Mar 11, 2024
adrian-prantl
approved these changes
Mar 11, 2024
kastiglione
deleted the
dl/lldb-Only-use-Swift-remark-diagnostics-for-logging
branch
kastiglione
added a commit
that referenced
this pull request
Mar 14, 2024
In `handleDiagnostics`, early exit from all Swift remarks. Remark diagnostics should not be handled as warnings/errors. At most, lldb should use remark diagnostics for logging, or progress events. By setting `EnableModuleLoadingRemarks` to true (#7857) there are remarks other than `module_loaded` that are emitted. These other remarks should be ignored in `handleDiagnostics`. rdar://121611925 (cherry-picked from commit b7ab938)
kastiglione
added a commit
that referenced
this pull request
Mar 14, 2024
In `handleDiagnostics`, early exit from all Swift remarks. Remark diagnostics should not be handled as warnings/errors. At most, lldb should use remark diagnostics for logging, or progress events. By setting `EnableModuleLoadingRemarks` to true (#7857) there are remarks other than `module_loaded` that are emitted. These other remarks should be ignored in `handleDiagnostics`. rdar://121611925 (cherry-picked from commit b7ab938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
handleDiagnostics, early exit from all Swift remarks. Remark diagnostics should not be handled as warnings/errors.At most, lldb should use remark diagnostics for logging, or progress events.
By setting
EnableModuleLoadingRemarksto true (#7857) there are remarks other thanmodule_loadedthat are emitted. These other remarks should be ignored inhandleDiagnostics.rdar://121611925