Pick fixes for Unions & tbaa.struct #8375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds extra test coverage for TBAA generation for copies of structs with union members. (cherry-picked from 6f29941)
Add test showing that tbaa.struct is generated when using TSan with relaxed-aliasing. (cherry-picked from 167b90d)
…vm#84386) Without this bail out, we may generate fields with null nodes as tags are generated by using getTypeInfo which has the same bail out. PR: llvm#84386 (cherry-picked from 83789ff)
…lvm#84370) At the moment,distinct fields for each union member are generated. When copying a union, we don't know which union member is active, so there's no benefit from recording the different fields. It can result in converting tbaa.struct fields to incorrect tbaa nodes when extracting fields. PR: llvm#84370 (cherry-picked from 5feaef6)
|
@swift-ci please test |
|
@swift-ci please test LLVM |
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci Please clean smoke test macOS platform |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.