[cherry-pick][stable/20230725] [clang][CodeCompletion] Allow debuggers to code-complete reserved identifiers #8383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntifiers (llvm#84891) (cherry picked from commit beb47e7)
…ved identifiers (llvm#84890) (cherry picked from commit 88bf640)
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon for LLDB users to dig into internal implementation details of system types (including the STL). LLDB's expression evaluator makes use of Clang's code-completion facilities but currently reserved identifeirs are filtered out (clang::Decls created in LLDB don't have valid locations, so we would also fail to code-complete any identifiers with reserved prefixes, not just ones from system headers).
This patch permits Clang to code-complete reserved identifiers iff we're in the debugger.
The associated LLDB tests: llvm#84890
rdar://124098023