Retire DynamicValueTypeInfoNeedsUpdate() (NFC) #8386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was introduced to detect a stale Swift scratch context. Today it doesn't make much sense, since all ValueObjects prefer to store their types as TypeSystemSwiftTypeRef types, and dynamic type resolution is done using type metadata, and not in SwiftASTContext space. This avoids a very costly initialization of the Swift compiler triggered by ValueObjectDynamicValue. rdar://124487859
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was introduced to detect a stale Swift scratch context. Today it doesn't make much sense, since all ValueObjects prefer to store their types as TypeSystemSwiftTypeRef types, and dynamic type resolution is done using type metadata, and not in SwiftASTContext space. This avoids a very costly initialization of the Swift compiler triggered by ValueObjectDynamicValue.
rdar://124487859