Skip to content

[Cherry-pick into next] Retire DynamicValueTypeInfoNeedsUpdate() (NFC) #8389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

[Cherry-pick into next] Retire DynamicValueTypeInfoNeedsUpdate() (NFC) #8389

merged 1 commit into from
Mar 13, 2024

Conversation

adrian-prantl
Copy link 

commit e472464f09ca33671344d43ce9236faf96be55eb
Author: Adrian Prantl <[email protected]>
Date:   Tue Mar 12 17:43:47 2024 -0700

    Retire DynamicValueTypeInfoNeedsUpdate() (NFC)
    
    This function was introduced to detect a stale Swift scratch
    context. Today it doesn't make much sense, since all ValueObjects
    prefer to store their types as TypeSystemSwiftTypeRef types, and
    dynamic type resolution is done using type metadata, and not in
    SwiftASTContext space. This avoids a very costly initialization of the
    Swift compiler triggered by ValueObjectDynamicValue.
    
    rdar://124487859

@adrian-prantl
Retire DynamicValueTypeInfoNeedsUpdate() (NFC)
bf8560b 
This function was introduced to detect a stale Swift scratch
context. Today it doesn't make much sense, since all ValueObjects
prefer to store their types as TypeSystemSwiftTypeRef types, and
dynamic type resolution is done using type metadata, and not in
SwiftASTContext space. This avoids a very costly initialization of the
Swift compiler triggered by ValueObjectDynamicValue.

rdar://124487859
(cherry picked from commit e472464)
@adrian-prantl adrian-prantl merged commit 0f711e7 into swiftlang:next Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrian-prantl