[DebugInfo] Add default true return for unexpected types in isUnsignedType #8438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IType" This reverts commit f6cbe78.
|
@swift-ci test llvm |
| } | ||
| // FIXME: the signedness should come from the expression where the type is | ||
| // used in, not the type itself. | ||
| return true; |
There was a problem hiding this comment.
On which code path dis this originally crash? Just checking whether this still addresses the original issue you wanted to solve.
There was a problem hiding this comment.
This was originally a DICompositeType with an DW_TAG_enumeration_type tag, whose base type was another DICompositeType.
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test llvm |
adrian-prantl
approved these changes
Mar 20, 2024
|
@swift-ci test llvm |
|
@adrian-prantl could you merge this? I ran the clang test suite locally and am getting the save clang scan deps failure without the patch, so it's unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.