Strip out -fno-implicit-modules and friends from ClangImporter options #8527
Conversation
|
@swift-ci test |
LLDB would rather control this itself. rdar://124699949
|
@swift-ci test |
| if (arg_sr == "-fno-implicit-modules" || | ||
| arg_sr == "-fno-implicit-module-maps") | ||
| continue; |
There was a problem hiding this comment.
should we put this behind a setting? could it cause issues?
There was a problem hiding this comment.
If we really need to we can replace with the extra clang flags setting already.
There was a problem hiding this comment.
So there should be no need to add another setting to control this.
There was a problem hiding this comment.
I'm worried that by doing this to fix the one bug report, we may create new unforeseen bugs. However, that's entirely speculative on my part. I guess we'll find out whether allowing implicit modules in the presence of explicit modules has any gotchas.
There was a problem hiding this comment.
I don't think this will do much to fix that specific bug, but I do think that the target's build settings should not control how LLDB imports modules.
|
@swift-ci test windows |
LLDB would rather control this itself.
rdar://124699949