Skip to content

🍒 [clang][ExtractAPI] Categories for external types and C++ fixes #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2024
Merged

🍒 [clang][ExtractAPI] Categories for external types and C++ fixes #8539

merged 5 commits into from
Apr 10, 2024

Conversation

daniel-grumberg
Copy link

@daniel-grumberg daniel-grumberg commented Apr 3, 2024 •
edited
Loading

Cherry picks of the following upstream commits:

rdar://88486038&125781262

daniel-grumberg and others added 4 commits April 3, 2024 21:51
@daniel-grumberg
[clang][ExtractAPI] Add ability to create multiple symbol graphs (llv…
31b0430 
…m#86676)

This extends ExtractAPI to take into account symbols defined in categories to
types defined in an external module.  This introduces 2 new command line flags,
`--symbol-graph-dir=DIR` and `--emit-extension-symbol-graphs`, when used
together this generates additional symbol graph files at
`DIR/[email protected]` for each external module that is
extended in this way.

Additionally this makes some cleanups to tests to make them more resilient and cleans up the `APISet` data structure.
@daniel-grumberg
Revert "[clang][ExtractAPI] Add ability to create multiple symbol gra…
ddd87a1 
…phs (llvm#86676)"

This failed the test suite due to missing DiagGroup for a new warning.

This reverts commit b31414b.
@evelez7 @daniel-grumberg
[clang][ExtractAPI] improve template argument name deduction (llvm#77716
2ab6927 
)

The names of template arguments in partial specializations or parameters
used as types might be mangled according to index and depth. Instead of
looping through parameter lists to find matches like we do now, they can
be deduced via their QualTypes or as written from the AST.
@daniel-grumberg
Reenable external categories (llvm#87357)
b061d3b 
Reenables b31414b.

Also adds a new warning for missing `--symbol-graph-dir` arg when
`--emit-extension-symbol-graphs` is provided. This also reverts the
commit that removed.
@daniel-grumberg
Copy link
Author

@swift-ci please test

@daniel-grumberg
Copy link
Author

@swift-ci please test

@QuietMisdreavus QuietMisdreavus mentioned this pull request Apr 4, 2024
Merged
@daniel-grumberg
Copy link
Author

@swift-ci please test

@fredriss fredriss merged commit 39d3e65 into swiftlang:swift/release/6.0 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus approved these changes

@zixu-w zixu-w zixu-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daniel-grumberg @QuietMisdreavus @zixu-w @fredriss @evelez7 @vitalybuka