Reland "[lldb][lit] Add MallocNanoZone envvar to Darwin ASan builds" … #8568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
llvm#88442) …(llvm#88436)" This reverts commit 1f5d130. The original commit checks that the host system is "Darwin" before setting the `MallocNanoZone` envvar, but on the Shell lit config this attribute does not exist at the point where it is being checked which leads to a build failure. This commit checks the host OS correctly. (cherry picked from commit c1a4456)
chelcassanova
force-pushed
the
cherrypick/reland-lldb-lit-mallocnanozone
branch
from
603fde8 to
b0e130f
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
JDevlieghere
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (llvm#88442)
…(llvm#88436)"
This reverts commit 1f5d130. The original commit checks that the host system is "Darwin" before setting the
MallocNanoZoneenvvar, but on the Shell lit config this attribute does not exist at the point where it is being checked which leads to a build failure.This commit checks the host OS correctly.
(cherry picked from commit c1a4456)