Add lldb-dap to Swift distributions (#88482) #8573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the lldb-dap executable in the MacOS and Linux distributions of Swift. Currently there is a commit in the Apple repo to do this for just MacOS swiftlang#8176. This PR extends this to both Linux and MacOS and brings the change upstream. @JDevlieghere @adrian-prantl
|
@JDevlieghere Is there any other branch this needs to be merged into to get it to be included in the main nightly and not just the 6.0 nightly? |
This PR covers both. We have an auto merger from the 6.0 ( |
|
@swift-ci test |
JDevlieghere
approved these changes
Apr 17, 2024
|
@JDevlieghere any reason this hasn't been merged yet? |
No reason other than I didn't realize you were waiting on me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the lldb-dap executable in the MacOS and Linux distributions of Swift. Currently there is a commit in the Apple repo to do this for just MacOS #8176. This PR extends this to both Linux and MacOS and brings the change upstream.
(Cherry-pick of 2c2377d)