[6.0][clang][cas] Don't include PGO-related files in the include-tree when they are not used #8599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not necessary when not performing codegen. (cherry picked from commit c7eede5)
…ommonInvocationForModuleBuild` into its own function (llvm#88447) The new function is about clearing out benign codegen options and can be applied for PCH invocations as well. (cherry picked from commit 6331024)
… they are not used PGO options are ignored for PCH invocations and may not be treated as dependencies from the build system, so don't add them in the include-tree. Otherwise we may get in a situation where such a file gets updated and an incremental build fails because of mismatched files in the include-tree of the PCH and the translation unit that uses it. rdar://125629656 (cherry picked from commit 4ccf152)
|
@swift-ci Please test |
jansvoboda11
approved these changes
Apr 18, 2024
bnbarham
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.