[lldb] Support reconstructing types compiled with a different abi name #8605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
requested changes
Apr 18, 2024
lldb/source/Plugins/ExpressionParser/Swift/SwiftExpressionParser.cpp
Outdated
Show resolved
Hide resolved
| @@ -4619,6 +4643,32 @@ SwiftASTContext::ReconstructType(ConstString mangled_typename) { | |||
| "\" was not found"); | |||
| } | |||
|
|
|||
| llvm::Expected<swift::TypeBase *> | |||
| SwiftASTContext::ReconstructType(ConstString mangled_typename) { | |||
There was a problem hiding this comment.
Unless we need a ConstString later anyway, maybe this should now take a StringRef?
There was a problem hiding this comment.
A lot of the helper functions used in ReconstructType take a ConstString, so I don't think that's work changing right now.
lldb/test/API/lang/swift/different_abi_name/TestSwiftDifferentABIName.py
Outdated
Show resolved
Hide resolved
lldb/test/API/lang/swift/different_abi_name/TestSwiftDifferentABIName.py
Outdated
Show resolved
Hide resolved
augusto2112
force-pushed
the
abi-name-lldb
branch
from
f9b54a0 to
058883e
Compare
|
@swift-ci test |
|
@swift-ci test Windows |
adrian-prantl
approved these changes
Apr 19, 2024
|
@swift-ci test windows |
|
@swift-ci test |
|
@swift-ci test windows |
Support expression evaluation for types in modules that were compiled with the -module-abi-name flag. These types have have the ABI module name serialized in debug information and the regular module name in the swift module. rdar://126719253
augusto2112
force-pushed
the
abi-name-lldb
branch
from
058883e to
d19cadc
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci Windows |
|
@swift-ci test windows |
adrian-prantl
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support expression evaluation for types in modules that were compiled with the -module-abi-name flag. These types have have the ABI module name serialized in debug information and the regular module name in the swift module.
rdar://126719253