[lldb] Disable tests affected by ld_new bug #8610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
force-pushed
the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
from
b2c4b4e to
a695d14
Compare
|
@swift-ci test |
JDevlieghere
approved these changes
Apr 19, 2024
kastiglione
changed the title
bulbazord
approved these changes
Apr 19, 2024
kastiglione
force-pushed
the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
from
62fdebb to
7057a64
Compare
|
@swift-ci test |
kastiglione
force-pushed
the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
from
7057a64 to
5eb88c8
Compare
|
@swift-ci test |
kastiglione
force-pushed
the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
from
5eb88c8 to
5a3094a
Compare
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Equivalent to the changes made in llvm#83941, except to support shell tests. (cherry picked from commit ecf7db8)
llvm#83941) When Apple released its new linker, it had a subtle bug that caused LLDB's TLS tests to fail. Unfortunately this means that TLS tests are not going to work on machines that have affected versions of the linker, so we should annotate the tests so that they only work when we are confident the linker has the required fix. I'm not completely satisfied with this implementation. That being said, I believe that adding suport for linker versions in general is a non-trivial change that would require far more thought. There are a few challenges involved: - LLDB's testing infra takes an argument to change the compiler, but there's no way to switch out the linker. - There's no standard way to ask a compiler what linker it will use. - There's no standard way to ask a linker what its version is. Many platforms have the same name for their linker (ld). - Some platforms automatically switch out the linker underneath you. We do this for Windows tests (where we use LLD no matter what). Given that this is affecting the tests on our CI, I think this is an acceptable solution in the interim. (cherry picked from commit d93a126)
kastiglione
force-pushed
the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
from
5a3094a to
b311f6c
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@JDevlieghere can you merge? |
kastiglione
deleted the
dl/lldb-Disable-shell-tests-affected-by-ld_new-bug-84246
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick llvm#83941 and llvm#84246