Skip to content

Add REQUIRES to 32-bit relocation tests in MCCAS #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add REQUIRES to 32-bit relocation tests in MCCAS #8616

merged 1 commit into from
Apr 22, 2024

Conversation

rastogishubham
Copy link

No description provided.

@rastogishubham
Copy link
Author

@swift-ci please test llvm

cachemeifyoucan
cachemeifyoucan approved these changes Apr 22, 2024
View reviewed changes
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefix the test file name with architecture next time so it is easy to tell and remember the required target.

@rastogishubham rastogishubham merged commit 77de02a into swiftlang:next Apr 22, 2024
@rastogishubham rastogishubham deleted the FixRelocTest branch April 22, 2024 18:17
@rastogishubham rastogishubham mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rastogishubham @cachemeifyoucan