Skip to content

Fix ptrauth after merge #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix ptrauth after merge #8651

merged 2 commits into from
Apr 29, 2024

Conversation

TNorthover
Copy link

Some ptrauth tests were failing after a recent merge. Two issues:

  1. We do need a slightly different CodeGen path for vtables in static initializers, so I reinstated that function.
  2. next emits more debug-info than the test was expecting, so allow other fields.

…gned.

In upstream LLVM this function was identical to `getVTableAddressPoint` in all
cases, so it was removed during ptrauth preparation. But with full support we
need to generate a special constant expr that signs the vtable when emitting a
static initializer for a global.

Should fix ptrauth-member-function-pointer.cpp and ptrauth-virtual-function.cpp
tests.
@TNorthover TNorthover merged commit 581fa32 into next Apr 29, 2024
@ahmedbougacha ahmedbougacha deleted the eng/fix-ptrauth-after-merge branch July 1, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant