Skip to content

[rebranch][cas] Add cc1 option -finclude-tree-preserve-pch-path #8655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

bnbarham
Copy link

Add the PCH path to the include tree, and add a way to control whether we use the original PCH path, or if we canonicalize it away to . For now, keep the default being to canonicalize it to as this improves canonicalization. However, a client (e.g. Swift) that knows its PCH path will be stable can use this option to allow enabling -gmodules, which requires a real path.

rdar://126370706
(cherry picked from commit 6f52d30)

Add the PCH path to the include tree, and add a way to control whether
we use the original PCH path, or if we canonicalize it away to <PCH>.
For now, keep the default being to canonicalize it to <PCH> as this
improves canonicalization. However, a client (e.g. Swift) that knows its
PCH path will be stable can use this option to allow enabling -gmodules,
which requires a real path.

rdar://126370706
(cherry picked from commit 6f52d30)
@bnbarham bnbarham requested a review from benlangmuir April 29, 2024 23:58
@bnbarham bnbarham merged commit 247b59a into swiftlang:stable/20240408 Apr 29, 2024
@bnbarham bnbarham deleted the missing-cherry-pick branch April 29, 2024 23:58
@bnbarham
Copy link
Author

This was merged to next on the 12th, so we just missed it in the branch off of next on the 8th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants