[lldb][Type Completion] Fix various redecl-completion issues that stem from the UseRedeclCompletion setting split
#8659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… definition is not found
|
@swift-ci test |
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 30, 2024
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
…nt redecl-completion fixes These were fixed in swiftlang#8659.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
We started hitting it after the fixes in swiftlang#8659. The assert can safely be disabled, so this patch does so to unblock CI.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
…nt redecl-completion fixes These were fixed in swiftlang#8659.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
We started hitting it after the fixes in swiftlang#8659. The assert can safely be disabled, so this patch does so to unblock CI.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
…nt redecl-completion fixes These were fixed in swiftlang#8659.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 3, 2024
We started hitting it after the fixes in swiftlang#8659. The assert can safely be disabled, so this patch does so to unblock CI.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 6, 2024
…nt redecl-completion fixes These were fixed in swiftlang#8659. (cherry picked from commit 582bd6d)
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
May 6, 2024
We started hitting it after the fixes in swiftlang#8659. The assert can safely be disabled, so this patch does so to unblock CI. (cherry picked from commit 41754cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging larger programs with the redecl-completion setting enabled was causing various crashes. This patch series resolves these. All of them were caused by either missed cherry-picks or incorrect
UseRedeclCompletionguards.Follow-ups from #8222