Remove MCCAS options in Scanner if not emitting Obj #8666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
requested review from
benlangmuir,
adrian-prantl and
felipepiovezan
|
@swift-ci please test |
rastogishubham
force-pushed
the
UpdateScanner
branch
2 times, most recently
from
7040426 to
4da2769
Compare
benlangmuir
reviewed
May 1, 2024
Remove the MCCAS options in the dependency scanner if the FrontendAction is not EmitObj. MCCAS should only be turned on when the compiler is emitting an object file.
rastogishubham
force-pushed
the
UpdateScanner
branch
from
4da2769 to
08b92a9
Compare
benlangmuir
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the MCCAS options in the dependency scanner if the FrontendAction is not EmitObj. MCCAS should only be turned on when the compiler is emitting an object file.
This patch is required when the XCBuild option to turn on MCCAS by default if caching is enabled is merged.