Introduce LockGuarded and make swift::ASTContext accesses thread safe #8719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LockGuarded is a generic wrapper around a resource to ensure exclusive access.
swift::ASTContext is not thread safe by default, wrap SwiftASTContext's swift::ASTContext in a LockGuarded. rdar://121409294
|
@swift-ci test |
|
Will this work when someone calls CompilerType::GetBitSize() for example? |
Nevermind. You created a thread-safe |
adrian-prantl
approved these changes
May 9, 2024
In preparation of refactoring SetupASTContext to use a call_once for initialization, make SetupASTContext and ParseAndImport member functions. This is needed so SwiftExpressionParser can acquire a ThreadSafeASTContext multiple times, so it doesn't need to hold on to that lock for the entirety of expression parsing.
Refactor SetupASTContext so it can be called multiple times, and rename it to GetASTContext to indicate that change.
After making ParseASTContext and GetASTContext methods, some function parameters are now unnecessarily as they are also ivars. Remove those parameters.
|
@swift-ci test |
In SwiftEnumDescriptor, replace the usages of swift::ASTContext with SwiftASTContext. swift::ASTContext is wrapped on a lock now, and SwiftEnumDescriptor would only use it to access SwiftASTContext, so pass the latter directly.
|
@swift-ci test |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift::ASTContext is not thread safe by default, wrap SwiftASTContext's swift::ASTContext in a LockGuarded.
rdar://121409294