[lldb] Display breakpoint locations using display name #8726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give language plugins the opportunity to provide a language specific display name. This will be used in a follow up commit. The purpose of this change is to ultimately display breakpoint locations with a more human friendly demangling of Swift symbols. (cherry picked from commit b52160d)
Adds a `show_function_display_name` parameter to `SymbolContext::DumpStopContext`. This parameter defaults to false, but `BreakpointLocation::GetDescription` sets it to true. This is NFC in mainline lldb, and will be used to modify how Swift breakpoint locations are printed. (cherry picked from commit 7ec8a33)
|
@swift-ci test |
|
@swift-ci test |
kastiglione
commented
May 9, 2024
| @@ -25,7 +25,7 @@ def test(self): | |||
| stream = lldb.SBStream() | |||
| bkpt.GetLocationAtIndex(0).GetDescription(stream, 1) | |||
| desc = stream.GetData() | |||
| self.assertIn("C.f<T>(T, U) -> ()", desc) | |||
| self.assertIn("C.f<T>(_:_:)", desc) | |||
There was a problem hiding this comment.
@adrian-prantl the switch from GetName to GetDisplayName results in this change.
|
@swift-ci test |
adrian-prantl
approved these changes
May 9, 2024
kastiglione
deleted the
dl/lldb-Display-breakpoint-locations-using-display-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
show_function_display_nameparameter toSymbolContext::DumpStopContext. This parameter defaults to false, butBreakpointLocation::GetDescriptionsets it to true.