[RuntimeDyld][ELF][AArch64] Fix resolveAArch64ShortBranch. #8761
Conversation
We don't know the load addresses when this function is called, so it shouldn't be trying to use them to determine whether or not the branch is short. Notably, this will fail in the case where the code is being loaded into a target in such a way that the section offsets differ between the process generating the code and the target process.
|
@swift-ci Please test |
|
Explanation: Code was added in https://reviews.llvm.org/D28108 to try to generate direct branches on aarch64 ELF systems when dynamically loading an object file, provided the address was in range. Unfortunately, the address computation used is erroneous, because we don't know the load addresses when the |
We mustn't use direct branches for cross-section branches, because doing so will result in problems if the sections aren't loaded at the same offsets in the target process as in the host process. rdar://127673408
|
@swift-ci Please test |
We don't know the load addresses when this function is called, so it shouldn't be trying to use them to determine whether or not the branch is short. Notably, this will fail in the case where the code is being loaded into a target in such a way that the section offsets differ between the process generating the code and the target process.